Apply HeadersLengthLimit to preamble in MultipartReader #59646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
captainsafia and
halter73
as code owners
ghost
added
the
area-networking
BrennanConroy
requested review from
Copilot
and removed request for
captainsafia and
halter73
captainsafia
approved these changes
Dec 28, 2024
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
LGTM! Mostly some syntax nits inside.
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50252
Helps with #58233
The
HeadersLengthLimitonMultipartReadernow applies to the inner stream on first read. What this means is that if the request has any preamble data (data before the first boundary), theHeadersLengthLimitwill now be applied to that preamble data. Before it was hardcoded to the default value of 16kb and not modifiable before being used.